[wp-trac] [WordPress Trac] #48881: Fix inline SVG error with wp_admin_css_color

WordPress Trac noreply at wordpress.org
Thu Dec 5 12:49:45 UTC 2019


#48881: Fix inline SVG error with wp_admin_css_color
-------------------------------------------------+-------------------------
 Reporter:  KZeni                                |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing reporter-    |     Focuses:  css,
  feedback                                       |  administration
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch needs-testing => has-patch needs-testing reporter-
     feedback


Comment:

 Hi there, welcome to WordPress Trac! Thanks for the ticket.

 As far as I can see, `url-friendly-colour` is only used for color schemes
 in core, however the end result in the inline SVG after running `npm run
 grunt build:css` looks like `%23e14d43` (as seen, for example, in the
 [https://build.trac.wordpress.org/browser/tags/5.3/wp-
 admin/css/colors/midnight/colors.css?marks=29#L27 Midnight scheme]),
 without an `'` or unencoded `#`.

 It might be that I'm misunderstanding the issue, could you describe the
 steps to reproduce it? Are you running the required build tasks for the
 CSS?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48881#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list