[wp-trac] [WordPress Trac] #47510: Developer tool - Best Practice - input comment field Does not use passive listeners
WordPress Trac
noreply at wordpress.org
Tue Dec 3 15:34:17 UTC 2019
#47510: Developer tool - Best Practice - input comment field Does not use passive
listeners
------------------------------------+--------------------------------------
Reporter: efilippucci | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.3.1
Component: Comments | Version: 5.2.1
Severity: major | Resolution:
Keywords: has-patch needs- | Focuses: javascript, performance
refresh |
------------------------------------+--------------------------------------
Changes (by andraganescu):
* keywords: has-patch => has-patch needs-refresh
Comment:
Hi @eherman24 the patch looks good but I checked and since we still
support IE11 there might be a need to check if passive is supported.
[https://caniuse.com/#feat=passive-event-listener Can I use] tells us IE11
doesn't support passive listeners and [https://developer.mozilla.org/en-
US/docs/Web/API/EventTarget/addEventListener#Safely_detecting_option_support
MDN advises] we create some way to detect prior to setting the option.
Could you please add this to the patch?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47510#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list