[wp-trac] [WordPress Trac] #48857: I found wrong variables in documentation of handle_bulk_actions-{$screen} filter.

WordPress Trac noreply at wordpress.org
Tue Dec 3 09:47:25 UTC 2019


#48857: I found wrong variables in documentation of handle_bulk_actions-{$screen}
filter.
-----------------------------------+------------------------------
 Reporter:  dilipbheda             |       Owner:  (none)
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Comments               |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  docs
-----------------------------------+------------------------------
Changes (by johnbillion):

 * keywords:  has-patch => has-patch 2nd-opinion
 * version:  trunk =>


Comment:

 Thanks for the patch @dilipbheda.

 I believe this filter is a special case because this it's applied in
 several places in core with differing parameter names, hence the generic
 `$items` variable name rather than the more specific `$comment_ids` which
 only applies to the bulk management of comments.

 That said, the inconsistency here isn't ideal. Some instances of the
 filter still use [https://github.com/WordPress/wordpress-
 develop/blob/9440ad966b0d63871792e7c933182750a7d22bba/src/wp-
 admin/edit.php#L186 the non-interpolated version of the filter name].

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48857#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list