[wp-trac] [WordPress Trac] #47752: Fix upload of .srt files

WordPress Trac noreply at wordpress.org
Sat Aug 31 17:35:04 UTC 2019


#47752: Fix upload of .srt files
-----------------------------------------+---------------------
 Reporter:  afercia                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.3
Component:  Upload                       |     Version:  5.0.1
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch has-screenshots  |     Focuses:
-----------------------------------------+---------------------

Comment (by killerbishop):

 @afercia - I agree that the environment variable `MAGIC` can cause the
 system version to be used, but by default, it uses the built-in magic file
 of PHP. On my install `MAGIC` is not set, so my testing is against
 whatever the PHP version provides.

 I updated to the latest `upstream/master` branch and tested the change
 from #44438 which is merged already. On my install of vvv, it is not
 functioning still with the file `mediaelement.srt`. For PHP 5.6.40 and
 7.2.21, it returns the MIME type ''text/html'' which does not appear like
 it will fall into the changes from #44438. The likely reason that it is
 calling it HTML is the fact the SRT file in question actually has HTML
 tags in the content.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47752#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list