[wp-trac] [WordPress Trac] #47580: Prevent output of invalid HTML in `_default_wp_die_handler()`

WordPress Trac noreply at wordpress.org
Thu Aug 29 17:34:08 UTC 2019


#47580: Prevent output of invalid HTML in `_default_wp_die_handler()`
--------------------------------------+----------------------------
 Reporter:  jeremyfelt                |       Owner:  audrasjb
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  5.3
Component:  Administration            |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note  |     Focuses:  accessibility
--------------------------------------+----------------------------

Comment (by dinhtungdu):

 Replying to [comment:16 SergeyBiryukov]:
 > Replying to [comment:11 audrasjb]:
 > > a full review, I think we should separate `p` and `.wp-die-message` in
 two CSS rules (even if they have the same CSS declarations) in `src/wp-
 admin/css/common.css`.
 >
 > Just curious, what was the reason for separating the rules? It seems
 that would make it harder to keep them consistent in the future.

 IMO, we don't need to keep them consistent in the future, they are two
 separated elements. We have their CSS rules identical for now because I
 want to keep the style as it was. In the future, it's more likely that
 we'll change the style for `.wp-die-message`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47580#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list