[wp-trac] [WordPress Trac] #47869: Missmatch between actual check and warning message for Background Updates

[WordPress Trac]

#47869: Missmatch between actual check and warning message for Background Updates
--------------------------+---------------------
 Reporter:  kraftner      |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  5.3
Component:  Site Health   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+---------------------
Changes (by Clorith):

 * milestone:  Awaiting Review => 5.3


Comment:

 For the first few states you mentioned, if your filter is added in a
 reasonable manner, it should be picked up just like in core, how are you
 implementing the filter you describe in point 2?

 The reason for the `current_user_can( 'update_core' )` in the
 `check_wp_version_check_exists()` call is to prevent disclosing a sites
 update state to those who have no reason to see it, just checking if a
 user is logged in isn't enough since you could be a subscriber. It might
 be viable to change this ot the new `view_site_health_checks` capability,
 but it also sort of makes sense to check that the user that's looking for
 the state of updates is one that can update core in the first place, so
 I'm a bit torn on this.

 I do agree with you on point 4, we should absolutely be checking the same
 things that core are checking here.

 So for your two courses of action, I think it's a little of both, and we
 can (and should)= definitely sort both :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47869#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform