[wp-trac] [WordPress Trac] #47116: Media Editor: Visible labels are not available on editing buttons
WordPress Trac
noreply at wordpress.org
Fri Aug 23 22:26:41 UTC 2019
#47116: Media Editor: Visible labels are not available on editing buttons
-------------------------------------------------+-------------------------
Reporter: afercia | Owner: nrqsnchz
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.3
Component: Media | Version:
Severity: normal | Resolution:
Keywords: has-screenshots wpcampus-report | Focuses: ui,
needs-design tooltips has-patch | accessibility
-------------------------------------------------+-------------------------
Comment (by sabernhardt):
@nrqsnchz Quick edit to your patch: the label text will still need the PHP
function to make sure the string is translatable, as it has been for each
of those 7 labels:
{{{
<?php esc_html_e( 'Crop' ); ?>
}}}
Also, mainly because of the need to translate, I would not recommend
changing the text label based on how long it is in English. It's probably
even wider in another language.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47116#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list