[wp-trac] [WordPress Trac] #47145: Feature Image dialog does not follow the dialog pattern

[WordPress Trac]

#47145: Feature Image dialog does not follow the dialog pattern
-------------------------------------------------+-------------------------
 Reporter:  anevins                              |       Owner:  afercia
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.2.3
Component:  Administration                       |     Version:
 Severity:  major                                |  Resolution:  fixed
 Keywords:  has-screenshots wpcampus-report      |     Focuses:  ui,
  has-patch needs-testing fixed-major            |  accessibility
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45866" 45866]:
 {{{
 #!CommitTicketReference repository="" revision="45866"
 Accessibility: Make the Media modal an ARIA modal dialog.

 For a number of years, the Media modal missed an explicit ARIA role and
 the required attributes for modal dialogs.

 This was confusing for assistive technology users, since they may not
 realize they're inside a dialog, and that consequently the keyboard
 interactions may be different from the rest of the page. Lack of an
 explicit label for the dialog was confusing as well, since assistive
 technology users didn't have an immediate sense of what the dialog is for.

 This change makes the Media modal meet the ARIA Authoring Practices
 recommendations, helping users better understand the purpose and
 interactions with the modal. Also, it makes sure to hide the rest of the
 page content from assistive technologies, until support for `aria-
 modal="true"` improves.

 Additionally:
 - moves the modal H1 heading to the beginning of the modal content
 - changes the modal left menu position to make visual and DOM order match
 - improves the `wp.media.view.FocusManager` documentation

 Props afercia.
 Merges [45572] to the 5.2 branch.
 Fixes #47145.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47145#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform