[wp-trac] [WordPress Trac] #47902: hook wp_pre_insert_user_data should return a WP_Error when returned empty

[WordPress Trac]

#47902: hook wp_pre_insert_user_data should return a WP_Error when returned empty
-------------------------+-----------------------------
 Reporter:  juliobox     |      Owner:  (none)
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Users        |    Version:  trunk
 Severity:  normal       |   Keywords:
  Focuses:               |
-------------------------+-----------------------------
 (This is a follow-up to #40545.)

 Hello there.

 In wp_insert_user() there is a lot of check of valid data or not, but
 since wp_pre_insert_user_data, the returned value is not checked at all.

 I know, you'll say "hey, you have to return something !" well, yes, but I
 want to shortcut and forbid this, so actually I'm returning
 "__return_empty_array" which is doing the job well, BUT is the admin area
 we still got the message "New user created." like nothing happened.

 I think we should add a new control here. (see patch)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47902>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform