[wp-trac] [WordPress Trac] #38415: New Custom Link menu item has a wrong fallback label

[WordPress Trac]

#38415: New Custom Link menu item has a wrong fallback label
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  afercia
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.2.3
Component:  Menus                                |     Version:  4.5
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots good-first-bug has-  |     Focuses:  ui
  patch needs-testing fixed-major                |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45828" 45828]:
 {{{
 #!CommitTicketReference repository="" revision="45828"
 Menus: Fix the Custom Links text fallback.

 When adding a Custom Link and leaving the "Link Text" field empty,
 WordPress used to set a default fallback text: "Menu Item".

 The changes in [36379] broke this behavior making the fallback text:
 `(Pending)`, with a leading space.

 Pending major refactoring of the Menus page (which is going to use a
 block-based user interface) this change just restores the original
 behavior by adding the fallback text to the related AJAX response.

 Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
 Merges [45727] to the 5.2 branch.
 Fixes #38415.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38415#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform