[wp-trac] [WordPress Trac] #41114: Installation: "Search Engine Visibility" not keeping checked on error

[WordPress Trac]

#41114: Installation: "Search Engine Visibility" not keeping checked on error
----------------------------+------------------------------
 Reporter:  screamingdev    |       Owner:  (none)
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  4.8
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+------------------------------
Changes (by donmhico):

 * keywords:   => has-patch


Comment:

 At first I thought that it might be the intended behaviour to always get
 the user to check but checking at source code
 {{{#!php
 <input name="blog_public" type="checkbox" id="blog_public" value="0" <?php
 checked( 0, $blog_public ); ?> />
 }}}
 We can see the `checked` function is being used. If the intent is to
 always make the user perform the check then `checked()` shouldn't be
 there.

 Anyway, my attached patch,
 [https://core.trac.wordpress.org/attachment/ticket/41114/41114.diff
 41114.diff], should fix this.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/41114#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform