[wp-trac] [WordPress Trac] #14459: Rotate Full Size Images on Upload

[WordPress Trac]

#14459: Rotate Full Size Images on Upload
-------------------------------------------------+-------------------------
 Reporter:  mrroundhill                          |       Owner:
                                                 |  mikeschroder
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  Media                                |     Version:  3.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-unit-  |     Focuses:
  tests                                          |
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:80 pbiron]:
 > I was going off what @mikeschroder said in [comment:52 #52], which I
 interpreted as his opinion that we should **not** do rotation (or
 flip/etc) on upload if we couldn't also preserve EXIF (and/or IPTC) in GD.

 Right, that's in case we overwrite the original uploaded image. I'm
 thinking we should keep the original but not use it on the front-end when
 we do the rotation.

 Also these images will generally be "big" by both file size and dimensions
 and not suitable for use on the internet (as they would be unedited
 photos). #47873 is for implementing the same handling for all of them:
 keep the original but not use it in WP.

 > I spent a little time trying to put a WP core wrapper around the
 [https://github.com/pel/pel Pel] library, for general EXIF/IPTC editing
 within core.  But quickly decided it wasn't worth it

 Yeah, thinking if we want to use Pel, it would need a new ticket (and
 quite a bit of testing).

 > What are the chances of WP putting some pressure upstream to get GD to
 preserve EXIF/IPTC/etc?

 I'd say not very likely :) Even if that's added it would take quite a bit
 of time until it gets in PHP and WP is able to use it.

 > So, when images are rotated/flipped/etc, should we extract the embedded
 thumbnail, rotate/flip/etc it and re-embed  it?  This applies whether the
 image is rotated/flipped/etc on upload or done interactively by a user.
 99% of users will never noticed, but just thought I'd mention it.

 Hm, think the embedded thumbnails were removed/not copied to the sub-sizes
 (or there was a ticket for that?). This is a basic optimization for web
 use, would be good to do it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/14459#comment:81>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform