[wp-trac] [WordPress Trac] #47863: Fix odd, unexpected output from shortcode_parse_attts
WordPress Trac
noreply at wordpress.org
Wed Aug 14 14:46:53 UTC 2019
#47863: Fix odd, unexpected output from shortcode_parse_attts
--------------------------------------+-----------------------------
Reporter: mauteri | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Shortcodes | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------------
Comment (by birgire):
Thanks for the update @mauteri
I don't think we need the count check part, isn't {{{$matches[1]}}} always
set?
The tests also seem to run successfully without the {{{trim()}}}.
Personally I prefer to a different pattern delimiter than {{{/}}}, when
there are many slashes and backslashes in the pattern, to make it more
readable.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47863#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list