[wp-trac] [WordPress Trac] #47528: Site Health: Add test for file checksums

[WordPress Trac]

#47528: Site Health: Add test for file checksums
-----------------------------------+-----------------------------
 Reporter:  swissspidy             |       Owner:  (none)
     Type:  enhancement            |      Status:  new
 Priority:  normal                 |   Milestone:  Future Release
Component:  Site Health            |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  site-health has-patch  |     Focuses:
-----------------------------------+-----------------------------

Comment (by killerbishop):

 @pgogy - I apologize if I'm not entirely getting this correct - but I want
 to make sure I understand what your asking for first. So are you thinking
 that a new DB table would get added to store the checksum list for the
 current version+locale combination and that the `get_core_checksums()`
 function would fetch from that table first before querying the API - or
 would this be specific to the health check?

 Right now, it's just calling the `get_core_checksums()` function. That
 function is documented as caching but I didn't see anything implemented
 inside that function's code to cache. I used the transient API in the
 health check to avoid repeated calls in a short span.

 I can see the value in not fetching unchanging checksum lists for future
 health checks. I wonder if that is better served in the
 `get_core_checksums()` implementation rather than at the health check
 level. The storage would need to be keyed on version and locale. If stored
 in a database - would this be global for multi-site? Even without the
 database storage - is it useful having the transient behavior moved inside
 the function? Any change here though would be a different ticket or is it
 OK to include that kind of change in a feature like this?

 Sorry if some of my questions seem out of place - I can ping you on Slack
 if that would work better.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47528#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform