[wp-trac] [WordPress Trac] #47867: wp_trim_excerpt and wp_trim_words don't validate the excerpt length (int)

WordPress Trac noreply at wordpress.org
Tue Aug 13 09:23:50 UTC 2019


#47867: wp_trim_excerpt and wp_trim_words don't validate the excerpt length (int)
--------------------------------------+------------------------------
 Reporter:  pikamander2               |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  General                   |     Version:  5.2.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by pikamander2):

 Hi @donmhico, thanks for the quick fix.

 My main concern with defaulting the value to 55 is that it changes a
 longstanding behavior. Any plugins or themes that are passing "" or null
 to that function are currently receiving zero words, but once the patch is
 applied they'll be receiving 55 words.

 In the case of Elementor Pro, for example, many users' Post Cards will
 suddenly change from this:

 https://i.imgur.com/qljC2Ec.png

 to this:

 https://i.imgur.com/SNnqn5g.png

 And because it's an obscure issue, they're gonna have no idea what caused
 it or how to fix it. That's going to lead to a lot of frustration.

 Granted, that's not necessarily WordPress's problem, and it might be
 better to just go ahead and "rip off the band-aid" so to speak, but it's
 definitely something to consider.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47867#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list