[wp-trac] [WordPress Trac] #47863: Fix odd, unexpected output from shortcode_parse_attts
WordPress Trac
noreply at wordpress.org
Tue Aug 13 01:17:13 UTC 2019
#47863: Fix odd, unexpected output from shortcode_parse_attts
--------------------------------------+-----------------------------
Reporter: mauteri | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Shortcodes | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------------
Comment (by mauteri):
Thanks @birgire, good points there. I've adjusted the trimming a bit.
Mostly just pulling off any hanging `/` at the end of the string with a
preg_replace before trimming whitespace. I also added a few more tests you
mentioned above with what I think the expected output would be given the
circumstance. Let me know of you agree or if you have any comments on the
additional tests.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47863#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list