[wp-trac] [WordPress Trac] #47863: Fix odd, unexpected output from shortcode_parse_attts
WordPress Trac
noreply at wordpress.org
Mon Aug 12 21:24:27 UTC 2019
#47863: Fix odd, unexpected output from shortcode_parse_attts
--------------------------------------+-----------------------------
Reporter: mauteri | Owner: SergeyBiryukov
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Shortcodes | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests | Focuses:
--------------------------------------+-----------------------------
Comment (by birgire):
I adjusted the inline docs and some WPCS in [attachment:"47863-2.diff"].
Added two trivial test cases.
I also think I would expect the inputs {{{'""'}}} and {{{'\'\''}}} to
return an empty array, as the inline docs mentioned:
{{{
* Returns empty array if trim( $text ) == '""'.
}}}
The tests in [attachment:"47863-2.diff"] run successfully on my install.
> OK (12 tests, 12 assertions)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47863#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list