[wp-trac] [WordPress Trac] #45917: Twenty Nineteen: Consider adding a search option in the page header

WordPress Trac noreply at wordpress.org
Mon Aug 12 19:08:09 UTC 2019


#45917: Twenty Nineteen: Consider adding a search option in the page header
---------------------------+------------------------------------
 Reporter:  kjellr         |       Owner:  (none)
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Future Release
Component:  Bundled Theme  |     Version:  5.0.2
 Severity:  normal         |  Resolution:
 Keywords:                 |     Focuses:  javascript, multisite
---------------------------+------------------------------------
Changes (by craigtommola):

 * focuses:   => javascript, multisite


Comment:

 Curious if this has been looked into further ... I'd suggest that there's
 a bug beneath the decision to leave out the search field. I'm working in a
 child theme of 2019 and added a search field both "long hand" and with
 get_search_form(). On pages which also have navigation (I'm working in a
 multisite network - some subsites do not have a menu / nav) the search
 won't work while within div.site-branding ... it loses focus when I try to
 insert my cursor.

 In the event listeners tab of Chrome dev tools, /wp-
 content/themes/twentynineteen/js/touch-keyboard-navigation.js?ver=1.1
 seems to be the culprit? If I comment out the wp_enqueue_script at /wp-
 content/themes/twentynineteen/functions.php:226 the search field works
 consistently.

 I'm probably going to end up with a bunch of extraneous wrappers to sort
 this out, but if there's a more correct solution, it'd be much
 appreciated.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45917#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list