[wp-trac] [WordPress Trac] #47767: Simplify and backport the local environment
WordPress Trac
noreply at wordpress.org
Mon Aug 12 02:01:31 UTC 2019
#47767: Simplify and backport the local environment
-------------------------------------+-----------------------
Reporter: pento | Owner: pento
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: needs-testing has-patch | Focuses:
-------------------------------------+-----------------------
Comment (by noisysocks):
This looks great! It's nice that we're able to avoid so much repetition. I
applied [attachment:"47767.16.diff"] and tested all of the commands on my
macOS machine and it's working as before.
I noticed some places where the JavaScript doesn't quite follow our
JavaScript coding standards and so ran the Gutenberg lint tool on these
changes:
{{{
$ cp ~/projects/gutenberg/.eslintrc.js .
$ npm install --no-save eslint-plugin-jest
$ npx eslint tools/local-env/scripts/*.js
/Users/robert/projects/wordpress-develop/tools/local-
env/scripts/install.js
2:7 error Identifier 'wait_on' is not in camel case camelcase
13:30 error Expected space(s) after '${' template-
curly-spacing
13:58 error Expected space(s) before '}' template-
curly-spacing
14:34 error Expected space(s) after '${' template-
curly-spacing
14:66 error Expected space(s) before '}' template-
curly-spacing
15:38 error Expected space(s) after '${' template-
curly-spacing
15:74 error Expected space(s) before '}' template-
curly-spacing
16:34 error Expected space(s) after '${' template-
curly-spacing
16:66 error Expected space(s) before '}' template-
curly-spacing
22:40 error Expected space(s) after '${' template-
curly-spacing
22:64 error Expected space(s) before '}' template-
curly-spacing
22:66 error A space is required before ']' array-bracket-
spacing
25:162 error Expected space(s) after '${' template-
curly-spacing
25:186 error Expected space(s) before '}' template-
curly-spacing
33:10 error Identifier 'wp_cli' is not in camel case camelcase
34:41 error Expected space(s) after '${' template-
curly-spacing
34:46 error Expected space(s) before '}' template-
curly-spacing
/Users/robert/projects/wordpress-develop/tools/local-env/scripts/start.js
12:58 error Expected space(s) after '${' template-curly-spacing
12:93 error Expected space(s) before '}' template-curly-spacing
12:121 error Missing semicolon semi
13:14 error Expected space(s) after '${' template-curly-spacing
13:26 error Expected space(s) before '}' template-curly-spacing
13:40 error Expected space(s) after '${' template-curly-spacing
13:73 error Expected space(s) before '}' template-curly-spacing
13:92 error Expected space(s) after '${' template-curly-spacing
13:116 error Expected space(s) before '}' template-curly-spacing
13:132 error Expected space(s) after '${' template-curly-spacing
13:156 error Expected space(s) before '}' template-curly-spacing
13:159 error Expected space(s) after '${' template-curly-spacing
13:183 error Expected space(s) before '}' template-curly-spacing
✖ 30 problems (30 errors, 0 warnings)
28 errors and 0 warnings potentially fixable with the `--fix` option.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47767#comment:38>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list