[wp-trac] [WordPress Trac] #47223: Site Health Check: "last missed cron" test too aggressive

[WordPress Trac]

#47223: Site Health Check: "last missed cron" test too aggressive
-------------------------------------------------+-------------------------
 Reporter:  DavidAnderson                        |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Site Health                          |     Version:  5.2
 Severity:  normal                               |  Resolution:
 Keywords:  site-health needs-testing has-patch  |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * keywords:  site-health needs-testing has-patch => site-health needs-
     testing has-patch needs-unit-tests


Comment:

 Replying to [comment:27 Clorith]:
 > I agree with comment:26 that it's better to look for worst cases, before
 checking for intermediary ones, so let's look for missed ones before
 seeing if any are late.

 This makes sense.

 These are the unit tests I'd like to see before this is committed:

 * Everything is dandy: Add a scheduled task to run in +3 minutes, ensure
 both the late and missed return `false`
 * Late cron jobs: Add a scheduled task to run in -16 minutes, ensure late
 returns `true`, missed returns `false`
 * Missed cron jobs: Add a scheduled task to run in -61 minutes, ensure
 both late and missed return `true`
 * No cron jobs: Ensure both late and missed return `WP_Error`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47223#comment:29>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform