[wp-trac] [WordPress Trac] #46349: Is your/this admin email still correct

[WordPress Trac]

#46349: Is your/this admin email still correct
-------------------------------------+-------------------------------------
 Reporter:  andraganescu             |       Owner:  andraganescu
     Type:  enhancement              |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.3
Component:  Site Health              |     Version:  5.1
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration,
  needs-docs needs-codex             |  ui-copy
-------------------------------------+-------------------------------------

Comment (by afercia):

 I'm still not sure to understand why there should be 2 links pointing at
 the same resource :)
 - the two links have different text and same destination: this is also a
 WCAG violation
 - boht links lack context, as also "Why is this important?" isn't clear
 when read out of context

 If it was up to me, I'd do it as in [attachment:"46349.4.diff"].
 Screenshot:

 [[Image(http://cldup.com/8CLcRcnEry.png)]]

 Not saying that's necessarily the best solution but at least there's just
 one link. Also, the text `learn more about ...` is pretty common in core.
 Found 31 occurrences.

 Other things in the patch (some of them should be implemented regardless
 of the text changes);
 - changed the document title to expand `admin` to `administration`
 - links with `target="_blank"` need the `(opens in a new tab)` visually
 hidden text: added
 - the `screen-reader-text` class requires `common.css` to be enqueued
 (unless we'd want to duplicate the rule somewhere but I wouldn't recommend
 it)
 - `common.css` also slightly changes the line-height of the H1
 - added some translators comments
 - CS for the whole file

 > Should we make the "Administration email verification" heading h2? Or
 rather, is it OK when the h1 is just a logo/image and has no text?

 From a practical perspective, the main H1 and the overall headings
 hierarchy has more to do with [https://make.wordpress.org/core/2015/10/28
 /headings-hierarchy-changes-in-the-admin-screens/ the way users find
 information on a page].

 I'd tend to think the logo shouldn't be a H1. Instead, the H1 should
 identify the main topic of the page. However, I'm not sure all the
 install/setup/login pages have text to identify the "main topic". Guess
 this should be reviewed across all these pages and addressed separately.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46349#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform