[wp-trac] [WordPress Trac] #47421: Media with fragments duplicate in enclosures

[WordPress Trac]

#47421: Media with fragments duplicate in enclosures
-------------------------------------------------+-------------------------
 Reporter:  dshanske                             |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Feeds                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch needs-      |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by archduck):

 Replying to [comment:4 dshanske]:
 > @archduck Why check for fragments when the strip fragment function
 strips regardless? Isn't in more efficient just to run everything through
 it?

 Good point. Checking for fragments with parse_url is an unnecessary step
 here.

 Especially since strip_fragment_from_url ''itself'' runs parse_url - and
 so urls with fragments would undergo parse_url a second time.

 Better to just send everything through it.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47421#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform