[wp-trac] [WordPress Trac] #45845: Use get_user_by in check_password_reset_key

WordPress Trac noreply at wordpress.org
Thu Aug 1 19:53:30 UTC 2019


#45845: Use get_user_by in check_password_reset_key
--------------------------------------+-----------------------------
 Reporter:  spacedmonkey              |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  5.3
Component:  Users                     |     Version:  3.1
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  good-first-bug has-patch  |     Focuses:  performance
--------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:21 SergeyBiryukov]:
 > So reintroducing [44780] as is seems fine now, without the extra
 `clean_user_cache()` calls.

 Ah, since the tests use a direct update query instead of
 `get_password_reset_key()`, the extra `clean_user_cache()` calls are still
 needed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45845#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list