[wp-trac] [WordPress Trac] #47573: Use strict comparison in wp-includes/taxonomy.php

WordPress Trac noreply at wordpress.org
Thu Aug 1 13:43:42 UTC 2019


#47573: Use strict comparison in wp-includes/taxonomy.php
-------------------------+-------------------------------
 Reporter:  andizer      |       Owner:  SergeyBiryukov
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  5.3
Component:  Taxonomy     |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  coding-standards
-------------------------+-------------------------------
Changes (by SergeyBiryukov):

 * focuses:   => coding-standards


Comment:

 For some context, we have to be extra careful with this kind of changes,
 as these values are sometimes an integer and sometimes a numeric string,
 causing various inconsistencies. See #16101, #22324, #25092, #25852,
 #43752, #44723 for example.

 I've double-checked [attachment:"47573.diff"] and made some adjustments to
 ensure the correct types when comparing.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47573#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list