[wp-trac] [WordPress Trac] #47048: Nav Menus Admin: Missing Deselect All text when toggling Select All

[WordPress Trac]

#47048: Nav Menus Admin: Missing Deselect All text when toggling Select All
--------------------------------+-----------------------------
 Reporter:  birgire             |      Owner:  (none)
     Type:  defect (bug)        |     Status:  new
 Priority:  normal              |  Milestone:  Awaiting Review
Component:  Menus               |    Version:  3.0
 Severity:  normal              |   Keywords:
  Focuses:  ui, administration  |
--------------------------------+-----------------------------
 Under {{{/wp-admin/nav-menus.php}}} we can select all menu items, by
 clicking on the "Select All" link.

 This will mark all visible items as checked.

 But it's odd having to click again on "Select All" to deselect all.

 I would expect "Select All" to change to "Deselect All" after the first
 click.

 References:

 PHP:

 https://core.trac.wordpress.org/browser/tags/5.1.1/src/wp-admin/includes
 /nav-menu.php#L623

 JS:

 https://core.trac.wordpress.org/browser/tags/5.1.1/src/js/_enqueues/lib
 /nav-menu.js#L1093

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47048>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform