[wp-trac] [WordPress Trac] #46999: Twenty Nineteen: Responsive Columns broken in WordPress 5.2 Beta

[WordPress Trac]

#46999: Twenty Nineteen: Responsive Columns broken in WordPress 5.2 Beta
---------------------------+------------------------------
 Reporter:  dianeco        |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by kjellr):

 * keywords:   => has-patch


Comment:

 > WordPress 5.2 introduces a 2 columns breakpoint on small devices
 https://github.com/WordPress/gutenberg/pull/12816 but it doesn't work on
 Twenty Nineteen. On 768px devices, the columns don't wrap in rows of 2 and
 the gutter isn't the same between each column.

 Thanks for the report, @dianeco. I've attached a patch that should fix
 this.

 **Before (768px):**

 [[Image(https://cldup.com/mBZWxVL37p-3000x3000.png)]]

 **After (768px):**

 [[Image(https://cldup.com/dQ7sh62FRp-3000x3000.png)]]

 While I was in there, I noticed that margin was also inconsistent between
 783–800px. I've included a small change to fix that as well.

 **Before (785px):**

 [[Image(https://cldup.com/UPox6p072N-3000x3000.png)]]

 **After (785px):**

 [[Image(https://cldup.com/dKQIlBiGhb-3000x3000.png)]]


 ----

 > Moreover, is it intended to have a gutter of 54px (32px set by the
 columns block + 1rem added by the theme) on large devices? By defaut
 Gutenberg set the value to 32px which is better for the content
 (especially on tablets), maybe it's not necessary to add 1 rem:

 You're right, this is no longer needed. It was originally added to more
 closely mimic the extra space that was included in the editor, but that
 extra space has since been removed there. I'm going to address this as
 part of #46643. 👍

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46999#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform