[wp-trac] [WordPress Trac] #44314: `user_confirmed_action_email_content` filter run on two different strings

[WordPress Trac]

#44314: `user_confirmed_action_email_content` filter run on two different strings
-------------------------------------------------+-------------------------
 Reporter:  desrosj                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.3
Component:  Privacy                              |     Version:  4.9.6
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-refresh needs-       |     Focuses:
  testing has-unit-tests                         |
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):

 * keywords:  has-patch needs-refresh => has-patch needs-refresh needs-
     testing has-unit-tests
 * milestone:  Future Release => 5.3


Comment:

 Thanks @coffee2code and everyone for the work on this.

 After reviewing the filters and documentation issues they present I've
 supplied a refresh
 ([https://core.trac.wordpress.org/attachment/ticket/44314/44314.3.diff
 44314.3.diff]) on @birgire's original patch which passes the $content
 along as well as updates the corresponding unit test to use the
 appropriate filter name.

 I've also added an @ignore and included a note on the filter that will be
 staying in order for the reference to be picked up in doc parsers.

 To illustrate the existing documentation issues below are some references
 which show how the filter has been parsed in multiple places with
 different descriptions. Also note none provide any context about how to
 differentiate the filters.
 https://developer.wordpress.org/reference/hooks/user_confirmed_action_email_content/
 https://wpseek.com/hook/user_confirmed_action_email_content/
 https://wp-kama.com/hook/user_confirmed_action_email_content
 https://developer.wordpress.org/plugins/privacy/privacy-related-options-
 hooks-and-capabilities/
 *In some cases the docs show the fulfillment info and others the confirmed
 export.

 Milestoning this to 5.3 in hopes to address it before it gestates too
 long.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44314#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform