[wp-trac] [WordPress Trac] #46696: Twenty Fourteen: Long non-breaking text strings can cause horizontal scrolling
WordPress Trac
noreply at wordpress.org
Fri Apr 19 16:20:27 UTC 2019
#46696: Twenty Fourteen: Long non-breaking text strings can cause horizontal
scrolling
----------------------------------------------+--------------------------
Reporter: ianbelanger | Owner: ianbelanger
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch has-screenshots commit | Focuses:
----------------------------------------------+--------------------------
Comment (by laurelfulford):
Thanks for tackling this @ianbelanger! I figured I could check these over
while this issue is discussed in #36346 :)
[attachment:"46696.diff"] looks good to me! Similar to my comment in
#46704, what do you think about adding the `-ms-` prefix to hyphens as
well, for Edge and IE 10-11? Like Twenty Fifteen, it looks like Twenty
Fourteen already uses it in its existing hyphen styles.
I also noticed the theme also formats prefixes like:
{{{
-webkit-hyphens: auto;
-moz-hyphens: auto;
-ms-hyphens: auto;
hyphens: auto;
}}}
... with extra spacing to line up the values. What do you think about
following that, too, for consistency with existing styles?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46696#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list