[wp-trac] [WordPress Trac] #46951: Editor: Backport packages containing bug fixes from Gutenberg 5.5

WordPress Trac noreply at wordpress.org
Wed Apr 17 18:10:26 UTC 2019


#46951: Editor: Backport packages containing bug fixes from Gutenberg 5.5
--------------------------+------------------------------
 Reporter:  aduth         |       Owner:  (none)
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Editor        |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------------------

Comment (by aduth):

 Out of the [https://github.com/WordPress/gutenberg/pull/15020
 aforementioned pull request with additional backporting], a subsequent
 packages publish was performed. The following packages were updated:

  - @wordpress/block-editor at 2.0.1
  - @wordpress/block-library at 2.4.4
  - @wordpress/blocks at 6.2.4
  - @wordpress/components at 7.3.1
  - @wordpress/dom at 2.2.4
  - @wordpress/e2e-tests at 1.1.4
  - @wordpress/edit-post at 3.3.4
  - @wordpress/editor at 9.2.4
  - @wordpress/format-library at 1.4.4
  - @wordpress/list-reusable-blocks at 1.3.4
  - @wordpress/nux at 3.2.4

 From the patch, I observe that `@wordpress/dom` package has updated in
 `package.json` by _three_ versions (rather than the expected _two_). In
 investigating this further, it appears this may have been missed in a
 previous ticket, as the current state of trunk is such that there's a
 mismatch between `package.json` and `script-loader.php`:

 https://github.com/WordPress/wordpress-
 develop/blob/774dcea/package.json#L72
 https://github.com/WordPress/wordpress-develop/blob/774dcea/src/wp-
 includes/script-loader.php#L242

 (tl;dr It's expected and in-fact a correction for a previously overlooked
 issue)

 >After performing the above using the changes in 46951.patch​ except for
 the package-lock.json file results in the patch 46951.2.patch​ which does
 not include the https to http changes. I'm not sure if future npm
 install's should include the --prefer-onliune flag or not, time will tell
 I guess but at least there is a sane workaround for now.

 While I was eventually successful here, one note is that local changes to
 `package-lock.json` should be reset for the corrected updates to be
 applied.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46951#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list