[wp-trac] [WordPress Trac] #46946: Site Health: Text adjustment (add a link and remove "we")
WordPress Trac
noreply at wordpress.org
Wed Apr 17 01:20:26 UTC 2019
#46946: Site Health: Text adjustment (add a link and remove "we")
-----------------------------------+---------------------
Reporter: birgire | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 5.3
Component: Text Changes | Version: trunk
Severity: normal | Resolution:
Keywords: site-health has-patch | Focuses:
-----------------------------------+---------------------
Comment (by birgire):
Thanks @mukesh27 and @subrataemfluence for the patches.
In [attachment:"46946.diff"] does the part:
> If any improvement needed then it will show on the ...
need an "is" after the "improvement" ? (I'm not a native English speaker).
Regarding the link in In [attachment:"46946-2.diff"], I would suggest
using:
{{{
esc_url( admin_url( 'site-health.php' ) )
}}}
instead of
{{{
esc_url( admin_url() . 'site-health.php' )
}}}
to e.g. make the path accessible in the {{{admin_url}}} filter.
> Also a related thought (since the text link was suggested). As the page
can turn into a long one when all or some sections are expanded, how about
adding the same link at the bottom of the page?
Thanks for the suggestion on @subrataemfluence. Maybe this consideration
would be better focused in a possible new ticket? I guess other admin
pages will reuse this design in the future. How to help navigate long
pages, in this new design, is a good question.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46946#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list