[wp-trac] [WordPress Trac] #46949: Site Health page item and type alignments need improvement for mobile version
WordPress Trac
noreply at wordpress.org
Tue Apr 16 16:27:46 UTC 2019
#46949: Site Health page item and type alignments need improvement for mobile
version
-------------------------------------------------+-------------------------
Reporter: subrataemfluence | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.2
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch site-health needs-design- | Focuses: ui,
feedback needs-refresh | administration
-------------------------------------------------+-------------------------
Changes (by garrett-eclipse):
* keywords: has-patch site-health needs-design-feedback => has-patch site-
health needs-design-feedback needs-refresh
Comment:
Thanks @subrataemfluence some minor feedback;
1. Drop the `min-width` as it's unnecessary to specifically exclude tiny
mobiles.
2. Combine and move the media queries to the bottom to follow the CS rules
for CSS;
“It is generally advisable to keep media queries grouped by media at the
bottom of the stylesheet.”
Reference - https://make.wordpress.org/core/handbook/best-practices
/coding-standards/css/#media-queries
Otherwise this works nicely.
Cheers
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46949#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list