[wp-trac] [WordPress Trac] #39997: Bundled Themes: Pass theme version number to wp_enqueue_style()
WordPress Trac
noreply at wordpress.org
Tue Apr 16 15:54:20 UTC 2019
#39997: Bundled Themes: Pass theme version number to wp_enqueue_style()
---------------------------+-----------------------
Reporter: parsmizban | Owner: desrosj
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.2
Component: Bundled Theme | Version: 4.7.2
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
---------------------------+-----------------------
Comment (by desrosj):
Replying to [comment:28 obenland]:
> Based on
[https://developer.wordpress.org/reference/functions/wp_get_theme/ the
function reference], [45213] seems backwards incompatible for Twenty Ten
and Twenty Eleven, as they were introduced before `wp_get_theme()` was.
@obenland Thanks for catching this.
> More of an edge case, but worth considering: Going from a date-based
cache bust to a version-based one will make testing themes in trunk harder
or we'll need alpha theme versions.
Counter argument is that this problem exists in `trunk` today (just with
hard coded values instead of versions) because stylesheet versions are
often not bumped when updated.
I think reverting and auditing the last updated dates for each stylesheet
would be fine. Only exception being Twenty Nineteen, which has used
`wp_get_theme()->get( 'Version' )` from the start.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39997#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list