[wp-trac] [WordPress Trac] #28326: List Tables don't update properly after Quick Edit
WordPress Trac
noreply at wordpress.org
Tue Apr 16 08:04:25 UTC 2019
#28326: List Tables don't update properly after Quick Edit
---------------------------------+-----------------------------------------
Reporter: wonderboymusic | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: Quick/Bulk Edit | Version:
Severity: normal | Resolution:
Keywords: bulk-reopened has- | Focuses: javascript, administration
patch |
---------------------------------+-----------------------------------------
Changes (by garrett-eclipse):
* keywords: needs-patch, bulk-reopened => bulk-reopened has-patch
Comment:
Hi @wonderboymusic thanks for the initial work on this.
I came across this while looking at #46017 which is to update the 'Mine'
comment count. Looking at the implementation there I was able to put an
initial patch together
[https://core.trac.wordpress.org/attachment/ticket/28326/28326.2.diff
28326.2.diff] to update the sticky counts.
Reusing the `getCount`, `updateCount` and `updateCountText` functions from
edit-comments.js with a few modifications this was fairly straight-
forward. I feel it would be worth looking into making this consistent
across the List Tables as there's several needs to update counts and a
common function would make sense. Moving these to common.js and making the
markup consistent across list tables would be the next step here.
Concerning the idea of removing the sticky item from the list. I
personally warn against removing the items from the current list view if
enacted upon via Quick Edit. Simply removing the 'Sticky' label in my eyes
would suffice, and would allow the user to undo their change. Removing the
item from the list forcing the user to find it again if they unstuck in in
error.
*In a large publication with hundreds of posts and numerous featured
(sticky) accidentally unsticking an item could be tragic and hard to
reverse.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28326#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list