[wp-trac] [WordPress Trac] #37782: Duplicate Page Entry in View All Pages when generating a Menu

[WordPress Trac]

#37782: Duplicate Page Entry in View All Pages when generating a Menu
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  garrett-eclipse
     Type:  defect (bug)             |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.2
Component:  Menus                    |     Version:  3.0
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-unit-      |     Focuses:  ui, administration,
  tests commit                       |  privacy
-------------------------------------+-------------------------------------

Comment (by garrett-eclipse):

 @birgire provided some great feedback via Slack which I've addressed in
 [https://core.trac.wordpress.org/attachment/ticket/37782/37782.14.diff
 37782.14.diff]

 The changes don't change functionality but makes the code more concise.
 1. Made the `if ( ! empty( $important_pages ) ) ` into an elseif.
 2. Dropped `$privacy_policy_page_obj` in favour of the pre-existing
 `$privacy_policy_page`
 3. Added @since 2.7.0 to _post_states
 4. Minor cleanup for structure

 All the best

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/37782#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform