[wp-trac] [WordPress Trac] #46813: wp_die() may generate doing_it_wrong notices, confusing other WP error handling

[WordPress Trac]

#46813: wp_die() may generate doing_it_wrong notices, confusing other WP error
handling
-------------------------------------------------+---------------------
 Reporter:  ohiosierra                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.2
Component:  Bootstrap/Load                       |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  servehappy has-patch has-unit-tests  |     Focuses:
-------------------------------------------------+---------------------

Comment (by schlessera):

 I agree with the above sentiment that Core should never throw
 `doing_it_wrong` notices in the first place. It just seems to send out a
 message of incompetence if Core is misusing itself...

 Also, filtering out all notices like that might cloak more serious issues
 down the road.

 Patch `46813.5.diff` seems like the way to go after some WPCS clean-up and
 an explicit declaration of the global (props @TimothyBlynJacobs for the
 review).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46813#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform