[wp-trac] [WordPress Trac] #46698: Twenty Nineteen: use better color names for the editor palette

[WordPress Trac]

#46698: Twenty Nineteen: use better color names for the editor palette
-----------------------------------------+--------------------------------
 Reporter:  afercia                      |       Owner:  (none)
     Type:  defect (bug)                 |      Status:  new
 Priority:  normal                       |   Milestone:  5.3
Component:  Bundled Theme                |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, accessibility
-----------------------------------------+--------------------------------

Comment (by aduth):

 > - use a meaningful name at least for the default colors? E.g. "Blue",
 "Dark blue"

 It should be reasonably straight-forward to do. There's already some prior
 art in the code to manage the default value for the `color` property. It
 would be a matter of doing the same for the `name` property and coming up
 with some meaningful name of the default.

 https://github.com/WordPress/wordpress-develop/blob/3eb83ad/src/wp-
 content/themes/twentynineteen/functions.php#L146-L153

 > - fallback to the color value (as Gutenberg does) for custom colors?
 `Color code: %s`

 Is this is referring to the color selector in the Customizer? I'm not too
 familiar with how it works, but there are a few opportunities to hook into
 a change in value to e.g. speak. The markup itself is a series of `div`
 elements, so I'm not sure what options exist for assigning the meaningful
 label there. It's also unclear if those changes would occur in the
 Customizer's color control, the "Color Picker" abstraction, or the
 underlying Iris project.

 https://github.com/WordPress/wordpress-
 develop/blob/master/src/js/_enqueues/lib/color-picker.js
 https://github.com/WordPress/wordpress-
 develop/blob/3eb83ad/src/js/_enqueues/wp/customize/controls.js#L4113-L4174
 https://automattic.github.io/Iris/

 > Edit: also, maybe the documentation should be improved a bit, as it
 seems the goal of the color names is not so clear.

 Agreed. I created an issue:
 https://github.com/WordPress/gutenberg/issues/14989

 Not sure if you had any specific thoughts about what that should include,
 in case you want to comment there.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46698#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform