[wp-trac] [WordPress Trac] #46683: Site Health: audit the translation functions

[WordPress Trac]

#46683: Site Health: audit the translation functions
-----------------------------------+-------------------------------
 Reporter:  afercia                |       Owner:  SergeyBiryukov
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  5.2
Component:  Administration         |     Version:  trunk
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  site-health has-patch  |     Focuses:  coding-standards
-----------------------------------+-------------------------------

Comment (by afercia):

 Coding standards: Variables declared with `var` still
 [https://make.wordpress.org/core/handbook/best-practices/coding-
 standards/javascript/#declaring-variables-withconstandlet need to be at
 the top of a function block]. In this specific case:
 https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/admin/site-
 health.js?rev=45178&marks=149-150#L138 I'm not sure why a variable is used
 in the first place. The string can be directly passed to `sprintf()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46683#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform