[wp-trac] [WordPress Trac] #46911: iframe in update-core.php

[WordPress Trac]

#46911: iframe in update-core.php
-----------------------------+-----------------------------
 Reporter:  madivad          |      Owner:  (none)
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Upgrade/Install  |    Version:  5.1.1
 Severity:  minor            |   Keywords:
  Focuses:                   |
-----------------------------+-----------------------------
 ''Flagged as component "upgrade/install" purely because i see nothing for
 core, and plugin/theming are two seperate areas''

 `update_core` uses an iframe to display the update progress. The problem
 with this it uses height:100% (which does not cause browsers to use the
 whole available space, I wish it did, but alas), and a min-height property
 which is set sufficiently small enough to not make small browsers force
 scrolling, but not large enough to fill even half of the usable space on
 my desktop. Often leaving a large void, and a scroll bar at the side which
 isn’t immediately obvious.

 As far as I've ever noticed, this is the only place (in themes and plugin
 updates) this is specifically used, although anywhere that uses frames,
 it's possible. Many other places scroll elegantly, just not here.

 The only solutions I have involve jquery or similar scripting, albeit
 relatively minor (ie requesting page size and injecting it into the
 document). Is this type of scripting taboo in WP?:

 1. As mentioned, retrieve the page height when loaded and insert that into
 `div.wrap`.
 1. Make sure each parent above the iframe is set to 100% (caveat below).
 1. don't use an iframe!

 I have tried mucking around with it, unfortunately it is only testable
 when you have several plugins or themes that need updating and I've just
 finished all the updates I need to do.

 The only way I can get it to achieve 100% of the usable space is to
 manually add “height 100%” to each of the parents above it. This isn't
 elegant as it spreads over the "thank you for creating with wordPress" and
 the version number at the bottom. Obviously the last `div#WPWRAP` goes too
 far, or, probably more correctly, this is influenced by the fact
 `#wpfooter` is positioned absolutely to the bottom and they simply
 overlap.

 I would love to actually have a solution, as i'd love to contribute, but I
 don't know the fix (other than not using an iframe!).

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46911>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform