[wp-trac] [WordPress Trac] #46813: wp_die() may generate doing_it_wrong notices, confusing other WP error handling

[WordPress Trac]

#46813: wp_die() may generate doing_it_wrong notices, confusing other WP error
handling
---------------------------------------------------+---------------------
 Reporter:  ohiosierra                             |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  5.2
Component:  Bootstrap/Load                         |     Version:  trunk
 Severity:  normal                                 |  Resolution:
 Keywords:  needs-refresh serve-happy needs-patch  |     Focuses:
---------------------------------------------------+---------------------
Changes (by spacedmonkey):

 * keywords:  has-patch needs-refresh => needs-refresh serve-happy needs-
               patch


Comment:

 I personally don’t like the current patch from @ohiosierra as it doesn’t
 fix the underlying issue, that calling the doing_it_wrong function
 anywhere in the shutdown handler is going to have this issue.

 I think we should use the doing_it_wrong_trigger_error filter and return
 false at the start of the wp_die function. This would fix the larger issue
 and cleaner.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46813#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform