[wp-trac] [WordPress Trac] #46595: Allow more than one valid recovery mode link
WordPress Trac
noreply at wordpress.org
Sat Apr 13 03:08:34 UTC 2019
#46595: Allow more than one valid recovery mode link
-------------------------------------------------+-------------------------
Reporter: flixos90 | Owner:
| timothyblynjacobs
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 5.2
Component: Bootstrap/Load | Version: trunk
Severity: normal | Resolution:
Keywords: servehappy has-patch has-unit-tests | Focuses:
dev-feedback |
-------------------------------------------------+-------------------------
Comment (by TimothyBlynJacobs):
Uploaded a patch with some minor code formatting/cleanup and docs.
Additionally, I moved the cron handling to the base `WP_Recovery_Mode`
class so that the key service remains pure. I also moved the `$token`
parameter to always come first, I think this helps make it more clear that
the `$token` identifies the `$key`. I think the `daily` schedule is also
sufficient since keys would only be generated every 4 hours.
----
Blurgh, that should be a .9 diff. I guess `grunt upload_patch` doesn't
look at `.patch` extensions for naming?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46595#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list