[wp-trac] [WordPress Trac] #46623: Site Health: possible confusion with red/orange badges in the "Passed Tests" section

WordPress Trac noreply at wordpress.org
Fri Apr 12 17:03:31 UTC 2019


#46623: Site Health: possible confusion with red/orange badges in the "Passed
Tests" section
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  desrosj
     Type:  enhancement                          |      Status:  closed
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:  trunk
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-screenshots site-health has-     |     Focuses:  ui,
  patch commit                                   |  administration
-------------------------------------------------+-------------------------
Changes (by desrosj):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45169" 45169]:
 {{{
 #!CommitTicketReference repository="" revision="45169"
 Site Health: Improve the test badge implementation.

 Label badges for each Site Health test currently display in either red,
 orange, or green, regardless of if the test passed or failed. This is
 confusing, as seeing red labels in the “Passed Test” section could alarm
 users (when really everything is OK and no action is required), and seeing
 green labels in the “Failed Tests” section would not appropriately
 encourage the user to take appropriate action.

 This change makes several improvements to the label badges:

 - Always right align the badges for consistent display.
 - Remove background fill for badges. Instead, use a border.
 - Use a consistent styling for all tests (passed and failed).
 - The text color no longer uses true black (#000000).
 - The `.badge.pink` CSS definition has been switched to `.badge.purple`,
 and the definitions for blue, gray, and green have also been updated to
 more closely follow the official WordPress color palette.

 Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce,
 mdwolinski, alexdenning.
 Fixes #46623.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46623#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list