[wp-trac] [WordPress Trac] #46898: WSOD Protection: Finalize email language
WordPress Trac
noreply at wordpress.org
Fri Apr 12 15:44:41 UTC 2019
#46898: WSOD Protection: Finalize email language
----------------------------------+---------------------
Reporter: TimothyBlynJacobs | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.2
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: servehappy has-patch | Focuses:
----------------------------------+---------------------
Comment (by birgire):
I was just wondering about the TBD in the email body :-) I see it's being
taken care of in [attachment:"46898.3.diff"].
There are some plugins that end with "Plugin" in their name:
https://wordpress.org/plugins/search/plugin
So one consideration regarding the strings:
{{{
'This was caused by the %s plugin.'
'This was caused by the %s theme.'
}}}
used in the email body, is to use instead:
{{{
'This was caused by the plugin: %s.'
'This was caused by the theme: %s.'
}}}
to avoid adjacent cases like:
{{{
This was caused by the Some Plugin plugin.
}}}
and have instead
{{{
This was caused by the plugin: Some Plugin.
}}}
Or use some another approach around this.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46898#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list