[wp-trac] [WordPress Trac] #46640: Classic Editor: the distraction-free button breaks keyboard navigation

[WordPress Trac]

#46640: Classic Editor: the distraction-free button breaks keyboard navigation
---------------------------------------+----------------------------
 Reporter:  afercia                    |       Owner:  (none)
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  5.3
Component:  Editor                     |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:  accessibility
---------------------------------------+----------------------------

Comment (by afercia):

 [attachment:"46640.2.diff"] tries to simplify things a bit.

 Looking at the original code, the `wp_adv` button is always added to the
 toolbar. Let's just add it to the default array of buttons and then:
 - when not mobile:
   - when free-distraction mode is available (which I guess it's the most
 common case) just add the `dfw` button at the last position
   - when it's not available, remove the `dfw` button, then add
 `fullscreen` and add again `dfw` as last button

 This way, the order of the buttons is the one we need and the availability
 of the buttons is the intended one. Also, added minor CSS adjustments to
 make the `dfw` button correctly aligned with the other buttons.

 @azaozz when you have a chance, I'd greatly appreciate your review. I'd
 like to move this to 5.2 as it's a long standing bug that would be nice to
 fix soon :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46640#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform