[wp-trac] [WordPress Trac] #46726: Site health: the site data is gathered twice on non-English locales

[WordPress Trac]

#46726: Site health: the site data is gathered twice on non-English locales
---------------------------------------------------+---------------------
 Reporter:  azaozz                                 |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  5.2
Component:  Administration                         |     Version:  trunk
 Severity:  normal                                 |  Resolution:
 Keywords:  site-health needs-testing 2nd-opinion  |     Focuses:
---------------------------------------------------+---------------------

Comment (by afercia):

 @azaozz lots of improvements! I'd consider just a couple things:

 The button text:
 "Copy site debug data to clipboard"
 I'd suggest to simplify: while technically correct, users are not supposed
 to know what "debug data" means. The rest of the text in the page (title,
 intro paragraphs) refers to "Site info" and "Information". Also, "debug"
 is a bit difficult to translate. I'd suggest something simpler like the
 previous text "Copy site info to clipboard".

 PHPCS:
 I'm afraid the build will fail :) I see the patch changes many alignments.
 I'm not saying I actually like the new PHPCS alignment rules, and probably
 I would have used the same alignments you used in this patch :) However,
 running `phpcs --standard=phpcs.xml.dist src/wp-admin/includes/class-wp-
 debug-data.php` reports now 114 "violations", mostly related to
 alignments.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46726#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform