[wp-trac] [WordPress Trac] #45317: Trash or trash, that is the question
WordPress Trac
noreply at wordpress.org
Mon Apr 8 18:19:45 UTC 2019
#45317: Trash or trash, that is the question
----------------------------------------------------+---------------------
Reporter: Presskopp | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 5.2
Component: Text Changes | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing has-unit-tests | Focuses:
----------------------------------------------------+---------------------
Changes (by garrett-eclipse):
* keywords: good-first-bug needs-patch => has-patch needs-testing has-
unit-tests
* milestone: Awaiting Review => 5.2
Comment:
Thanks @aandrewdixon I appreciate the initial patch. I've uploaded another
version to include a few more strings;
'Moved to the Trash.' - wp-includes/script-loader.php
'Whether to bypass Trash and force deletion.' - wp-includes/rest-
api/endpoints/class-wp-rest-comments-controller.php
'Whether to bypass Trash and force deletion.' - wp-includes/rest-
api/endpoints/class-wp-rest-posts-controller.php
*I also updated some comments and some of the qunit tests so they didn't
fail due to the string changes.
The only instance I left alone was the one found on the block editor
(Gutenberg) as it's already been handled upstream;
https://github.com/WordPress/gutenberg/pull/14591
--
Ticket URL: <https://core.trac.wordpress.org/ticket/45317#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list