[wp-trac] [WordPress Trac] #46734: Site Health: Add actions to all site status tests

[WordPress Trac]

#46734: Site Health: Add actions to all site status tests
-------------------------------------------------+-----------------------
 Reporter:  garrett-eclipse                      |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  5.2
Component:  Administration                       |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  site-health has-patch needs-testing  |     Focuses:  ui, docs
-------------------------------------------------+-----------------------

Comment (by garrett-eclipse):

 Thanks @Clorith I appreciate the review/feedback.

 Replying to [comment:9 Clorith]:
 > The reason you want to use `%1$s` and similar is if there are multiple
 attributes within a translation string that are better suites in a
 different order. Here the order is fixed, the first element (the link)
 always has to go inside the `a` tag and the second one, the string, is
 always the second one. Adding ordered replacements here add a potential
 failure element if used incorrectly so as the coding standards don't state
 that they must be used I'd prefer the use of the fixed format when
 possible, just to be on the safe side.
 This makes sense for sure, might be nice to get that into the coding
 standards, within my updated patch I've set all static strings to use `%s`
 and left the translatable strings using the `%1$s` convention.

 > We should also make the URL to the support area translatable as
 suggested.
 I've updated the support URL to make it translatable and searched core to
 find all references I could and they were all translatable.

 And one final addition with the actions being fairly consistent I updated
 the 'Read more about why you should use HTTPS' link to use the convention
 making it an external link w/ the icon.

 Would love another review and testing, uploaded screens to illustrate
 changes.

 Other notes;
 - There's no filter for inactive themes hence why it doesn't have the same
 second action link that plugins has.
 - The 'One or more recommended modules are missing' section has a link to
 the 'the team handbook', should this be an action link?
 - Is there a handbook URL for 'Background updates are not working as
 expected'?
 - Which WP.org links should be translatable? Some like support make sense
 but others don't have variants so could be removed from the load on
 translators. Below is recon on this for `class-wp-site-health.php`;
 Translatable;
 https://make.wordpress.org/hosting/handbook/handbook/server-environment
 /#php-extensions
 https://wordpress.org/about/requirements/
 https://wordpress.org/support
 https://wordpress.org/support/article/why-should-i-use-https/
 Not Translatable;
 https://wordpress.org/support/article/debugging-in-wordpress/

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46734#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform