[wp-trac] [WordPress Trac] #46726: Site health: the site data is gathered twice on non-English locales

WordPress Trac noreply at wordpress.org
Sun Apr 7 03:57:31 UTC 2019


#46726: Site health: the site data is gathered twice on non-English locales
---------------------------------------------------+---------------------
 Reporter:  azaozz                                 |       Owner:  (none)
     Type:  defect (bug)                           |      Status:  new
 Priority:  normal                                 |   Milestone:  5.2
Component:  Administration                         |     Version:  trunk
 Severity:  normal                                 |  Resolution:
 Keywords:  site-health needs-testing 2nd-opinion  |     Focuses:
---------------------------------------------------+---------------------
Changes (by azaozz):

 * keywords:  needs-patch site-health => site-health needs-testing 2nd-
               opinion


Comment:

 In 46726.diff:
 - In `WP_Debug_Data::debug_data()` format the site data in two sets:
 "text", intended for general use, and "debug" intended (mostly) for
 support personal and developers. The "text" strings are translated, the
 "debug" are more concise and in English.
 - Fix few nested ternaries.
 - Make all sub-arrays associative.

 @Clorith could you test please :) Now the multi-dimensional array returned
 by `WP_Debug_Data::debug_data()` contains both English and translated
 strings. Left both "copy to clipboard..." buttons but wondering if we
 should leave only the one that copies the "debug" formatted data. Also
 remover/reused the `$type` param. Think it was there to eventually export
 the array in another format, perhaps JSON, but was unused?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46726#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list