[wp-trac] [WordPress Trac] #39776: add priority argument to add_submenu_page() function
WordPress Trac
noreply at wordpress.org
Fri Apr 5 15:36:22 UTC 2019
#39776: add priority argument to add_submenu_page() function
------------------------------------------+-----------------------------
Reporter: alexvorn2 | Owner: welcher
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.3
Component: Menus | Version: 4.7.2
Severity: normal | Resolution:
Keywords: has-patch dev-feedback early | Focuses: administration
------------------------------------------+-----------------------------
Comment (by welcher):
I've reworked the patch with a new approach that standardizes the
insertion point based on the number of items in the array instead of the
actual index number.
The only thing I am a little concerned about is that part of this approach
uses `array_merge` which doesn't preserve the array keys. Unit tests still
pass but I'd love any other feedback on whether those keys are actually
used anywhere that this change will break.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/39776#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list