[wp-trac] [WordPress Trac] #46045: Sandboxed live editing of PHP files doesn't work together with WSOD protection

[WordPress Trac]

#46045: Sandboxed live editing of PHP files doesn't work together with WSOD
protection
----------------------------------+-----------------------
 Reporter:  ocean90               |       Owner:  flixos90
     Type:  defect (bug)          |      Status:  assigned
 Priority:  normal                |   Milestone:  5.2
Component:  Bootstrap/Load        |     Version:  trunk
 Severity:  normal                |  Resolution:
 Keywords:  servehappy has-patch  |     Focuses:
----------------------------------+-----------------------
Changes (by flixos90):

 * keywords:  needs-patch servehappy => servehappy has-patch
 * owner:  (none) => flixos90
 * status:  new => assigned


Comment:

 This is caused because the fatal error handler treats such errors,
 although in this case it shouldn't.

 We actually noticed this is also affecting other areas:

 * When you resume a plugin/theme that is still broken, you will end up in
 a redirect loop.
 * When you activate a plugin/theme that is still stored as paused/broken,
 you will end up in a redirect loop too.

 [attachment:"46045.diff"] fixes this:
 * It introduces a `WP_SANDBOX_SCRAPING` constant and sets it whenever it
 is loading plugin/theme code in some "sandbox" mode.
 * The fatal error handler bails if that constant is set and true so that
 it no longer conflicts.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46045#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform