[wp-trac] [WordPress Trac] #44397: Argument type does not match: theme.php

WordPress Trac noreply at wordpress.org
Fri Apr 5 13:29:22 UTC 2019


#44397: Argument type does not match: theme.php
------------------------------+----------------------------
 Reporter:  subrataemfluence  |       Owner:  williampatton
     Type:  enhancement       |      Status:  accepted
 Priority:  normal            |   Milestone:  5.3
Component:  Themes            |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  docs
------------------------------+----------------------------
Changes (by williampatton):

 * keywords:  has-patch 2nd-opinion => has-patch
 * owner:  (none) => williampatton
 * status:  new => accepted
 * milestone:  Awaiting Review => 5.3


Comment:

 To me this looks like a good improvement to the documentation that is
 better at showing how the function works at a glance. The spaces look off
 to me though and I don't think they fit within coding styles. There should
 be no spaces between the types like `string|bool`.

 Also could we maybe go the other way around like `bool|string` since the
 Boolean is the default?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/44397#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list